In this paper,with shear device, shear test of discontinuties with different rockproporties in rock mass under various surface roughness and different normal stress is investigated,the com mon shear strangth criterion of discontin uties is set up as follows.