Aiming at the difficulty optical cable-maintaining, this paper issues an intelligent diagnosis system based on GIS and expert system. To improve the optical cable-maintaining efficiency, the rules of the expert system are established according to the characteristic of the optical cable faults in the OTDR output. And the GIS is also established contained the information of the optical cable and the region the cable locates in.